Wrong macro used for EmotionBubblesOAM #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's actually just the last 2 bytes of 4 OAM entries, see WriteOAMBlock for when it is used. BC is pre-loaded with the x and y pixels, whereas de (emotionBubblesOAM) is the tile id and attributes only. Not sure if there's a specific macro for this type of declaration.
|
Nice, thank you for noticing this! There's more OAM block data with this problem too, e.g. Also, nitpick, but the comment generally goes below the label, not above. (Yes we're very inconsistent about this.) |
PokefanMarcel
pushed a commit
to PokefanMarcel/pokered
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's actually just the last 2 bytes of 4 OAM entries, see WriteOAMBlock for when it is used. BC is pre-loaded with the x and y pixels, whereas de (emotionBubblesOAM) is the tile id and attributes only. Not sure if there's a specific macro for this type of declaration.